cfg/gtk.cfg: Remove incorrect GIOChannel destructors#8069
Open
jtojnar wants to merge 1 commit intodanmar:mainfrom
Open
cfg/gtk.cfg: Remove incorrect GIOChannel destructors#8069jtojnar wants to merge 1 commit intodanmar:mainfrom
jtojnar wants to merge 1 commit intodanmar:mainfrom
Conversation
Owner
|
The cppcheck-premium failure is not your fault. I have updated the license in the upstream repo. So if you rebase and rerun that job it should succeed. |
`shutdown` and `close` methods do not actually unref the channel:
The channel will not be freed until the last reference is dropped using g_io_channel_unref().
https://docs.gtk.org/glib/method.IOChannel.close.html
https://docs.gtk.org/glib/method.IOChannel.shutdown.html
jtojnar
force-pushed
the
glib-channel-non-desctructors
branch
from
bfe9679 to
fabde6a
Compare
|
Collaborator
|
Thanks for your contribution. Can you add a test to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutdownandclosemethods do not actually unref the channel:https://docs.gtk.org/glib/method.IOChannel.close.html
https://docs.gtk.org/glib/method.IOChannel.shutdown.html